Ensure DHT protocol ID matches Starknet spec #2291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
=======================================
Coverage 75.41% 75.41%
=======================================
Files 107 107
Lines 11404 11404
=======================================
Hits 8600 8600
Misses 2151 2151
Partials 653 653 ☔ View full report in Codecov by Sentry. |
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
3 times, most recently
from
c4f5ce3
to
ee1b5ee
Compare
Use dht.ProtocolExtension to set chainID in protocol ID format for DHT. Add test to verify protocol ID format for different networks: - /starknet/SN_SEPOLIA/kad/1.0.0 for Sepolia - /starknet/SN_MAIN/kad/1.0.0 for Mainnet The change ensures that DHT protocol follow latest Starknet specification.
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
ee1b5ee
to
ff56ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated DHT protocol ID to use dht.ProtocolExtension(chainId) for setting the chain ID in the protocol format. Added a test to verify:
• /starknet/SN_SEPOLIA/kad/1.0.0 for Sepolia
This change ensures that the DHT protocol ID aligns with the latest Starknet specification.